Skip to content

Conversation

@juanis2112
Copy link
Contributor

What kind of change does this PR introduce?

Bug Fix

What is the current behavior?

When running scorecard on the repo: https://github.com/IBM/vllm I run into the following error:

Error: check runtime error: Contributors: internal error: Client.Repositories.ListContributors: error during contributorsHandler.setup: error during ParseFile: line 55: unexpected character '^' at position 17
2025/08/25 12:22:59 error during command execution: check runtime error: Contributors: internal error: Client.Repositories.ListContributors: error during contributorsHandler.setup: error during ParseFile: line 55: unexpected character '^' at position 17
exit status 1

What is the new behavior (if this is a feature change)?**

The Codeowners file is skipped if there are parsing errors found so now running scorecard on the repo https://github.com/IBM/vllm shows a score instead of error.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4768

Special notes for your reviewer

I plan to open an issue in the hmarr/codeowners
package, as I believe they could benefit from supporting the ^ character in their parsing patterns. Regardless, it’s better for Scorecards to skip the CODEOWNERS file if a parsing error occurs and still produce a score, rather than invalidating the entire check. This change addresses that need.

We could optionally print a message to inform the user that a CODEOWNERS file was skipped, happy to add that if it’s useful.

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@juanis2112 juanis2112 requested a review from a team as a code owner November 18, 2025 02:38
@juanis2112 juanis2112 requested review from raghavkaul and spencerschrock and removed request for a team November 18, 2025 02:38
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 18, 2025
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to open an issue in the hmarr/codeowners
package, as I believe they could benefit from supporting the ^ character in their parsing patterns

Is that a valid CODEOWNERS character? I noticed the upstream VLLM fixed their codeowners, so I suspect it was a temporary mistake.

vllm-project/vllm@cf278ff

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.59%. Comparing base (353ed60) to head (53ed294).
⚠️ Report is 282 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4851      +/-   ##
==========================================
+ Coverage   66.80%   69.59%   +2.78%     
==========================================
  Files         230      251      +21     
  Lines       16602    15657     -945     
==========================================
- Hits        11091    10896     -195     
+ Misses       4808     3891     -917     
- Partials      703      870     +167     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks

@spencerschrock spencerschrock deployed to integration-test November 20, 2025 16:17 — with GitHub Actions Active
@spencerschrock spencerschrock enabled auto-merge (squash) November 20, 2025 16:17
@spencerschrock spencerschrock merged commit 1d52e15 into ossf:main Nov 20, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Contributors check fails on CODEOWNERS with ^ character

2 participants