Skip to content

Conversation

@Almenon
Copy link

@Almenon Almenon commented Feb 18, 2023

This should fix #6. Relevant: https://stackoverflow.com/questions/65326080/python-setup-config-install-requires-good-practices. I confirmed that packj audit and auth works with the pinned versions.

It also adds directions for avoiding #10

version pinning needed to avoid bad versions
**Windows**: Install [WSL - Ubuntu](https://apps.microsoft.com/store/detail/ubuntu/9PDXGNCFSCZV). In WSL, run `sudo apt update;sudo apt install python3-pip;pip install pip --upgrade;pip install pyopenssl --upgrade`. Make sure to add `~/.local/bin` to your PATH. Now you can run the linux command above.

```
bundle install
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't do anything if you just install through pip, so I deleted this section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for auditing Rubygems packages.

Copy link
Collaborator

@ashishbijlani ashishbijlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test these changes with multiple Python versions.

**Windows**: Install [WSL - Ubuntu](https://apps.microsoft.com/store/detail/ubuntu/9PDXGNCFSCZV). In WSL, run `sudo apt update;sudo apt install python3-pip;pip install pip --upgrade;pip install pyopenssl --upgrade`. Make sure to add `~/.local/bin` to your PATH. Now you can run the linux command above.

```
bundle install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for auditing Rubygems packages.


# this grabs the requirements from requirements.txt
REQUIREMENTS = [i.strip().split('==')[0] for i in open(os.path.join(here, "requirements.txt")).readlines()]
REQUIREMENTS = [i.strip() for i in open(os.path.join(here, "requirements.txt")).readlines()]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning deps is ideal, but this results in incompatibilities with different Python versions. I will test this.

@Almenon
Copy link
Author

Almenon commented Feb 20, 2023

This is needed for auditing Rubygems packages.

bundle install won't do anything without the Gemfile. What about replacing it with this then?: For auditing rubygems please install from source or use the docker image.

Pinning deps is ideal, but this results in incompatibilities with different Python versions. I will test this.

Thanks for the testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails on some google shit

2 participants