-
Notifications
You must be signed in to change notification settings - Fork 37
Fix pip installation #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
version pinning needed to avoid bad versions
| **Windows**: Install [WSL - Ubuntu](https://apps.microsoft.com/store/detail/ubuntu/9PDXGNCFSCZV). In WSL, run `sudo apt update;sudo apt install python3-pip;pip install pip --upgrade;pip install pyopenssl --upgrade`. Make sure to add `~/.local/bin` to your PATH. Now you can run the linux command above. | ||
|
|
||
| ``` | ||
| bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't do anything if you just install through pip, so I deleted this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for auditing Rubygems packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will test these changes with multiple Python versions.
| **Windows**: Install [WSL - Ubuntu](https://apps.microsoft.com/store/detail/ubuntu/9PDXGNCFSCZV). In WSL, run `sudo apt update;sudo apt install python3-pip;pip install pip --upgrade;pip install pyopenssl --upgrade`. Make sure to add `~/.local/bin` to your PATH. Now you can run the linux command above. | ||
|
|
||
| ``` | ||
| bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for auditing Rubygems packages.
|
|
||
| # this grabs the requirements from requirements.txt | ||
| REQUIREMENTS = [i.strip().split('==')[0] for i in open(os.path.join(here, "requirements.txt")).readlines()] | ||
| REQUIREMENTS = [i.strip() for i in open(os.path.join(here, "requirements.txt")).readlines()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning deps is ideal, but this results in incompatibilities with different Python versions. I will test this.
Thanks for the testing! |
This should fix #6. Relevant: https://stackoverflow.com/questions/65326080/python-setup-config-install-requires-good-practices. I confirmed that packj
auditandauthworks with the pinned versions.It also adds directions for avoiding #10