chore: consolidate CI workflows #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename go.yml to test.yml (workflow name: Test) - Rename golangci-lint.yml to lint.yml (workflow name: Lint) - Delete redundant ci.yml - Move vet from OS matrix to single Ubuntu job - Move format-check from ci.yml to test.yml 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates three overlapping GitHub Actions CI workflows into two cleaner, more maintainable workflows by eliminating redundancy and better organizing CI responsibilities.
- Removes the redundant
ci.ymlworkflow and distributes its functionality between the remaining workflows - Renames workflows for clarity:
go.yml→test.yml(Build Status → Test) andgolangci-lint.yml→lint.yml(golangci-lint → Lint) - Optimizes CI execution by running static analysis tools (vet, format-check, verify-mod) only on Ubuntu instead of across the OS matrix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/test.yml |
Renamed from go.yml; added dedicated jobs for vet, format-check, and verify-mod that run only on Ubuntu; moved test execution into the matrix job |
.github/workflows/lint.yml |
Renamed from golangci-lint.yml; simplified job naming from golangci to lint for consistency |
.github/workflows/ci.yml |
Deleted redundant workflow; its functionality (vet, format-check) migrated to test.yml while linting remains in lint.yml |
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:47
- [nitpick] The go-version value should be consistently formatted across all workflows. In
lint.ymlit's quoted ('1.24.x') while here it's unquoted (1.24.x). While both formats work, using consistent formatting improves maintainability. Consider either adding quotes here to matchlint.yml, or removing them fromlint.ymlto match this file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate three overlapping CI workflows into two cleaner ones:
Before
ci.yml(CI) - ran lint+vet+test+format on Ubuntugo.yml(Build Status) - ran build+vet+test on 3 OS matrix + coveragegolangci-lint.yml(golangci-lint) - dedicated lintingAfter
test.yml(Test) - test on 3 OS, vet/format/verify-mod on Ubuntu, coverage on pushlint.yml(Lint) - dedicated linting with golangci-lint-actionChanges
go.yml→test.yml, workflow nameBuild Status→Testgolangci-lint.yml→lint.yml, workflow namegolangci-lint→Lintci.ymlvetfrom OS matrix to single Ubuntu job (per user request)format-checkjob from ci.yml to test.yml🤖 Generated with Claude Code