Skip to content

tests/inst: convert more sh-inline to xshell #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samzeter wants to merge 4 commits into
base: main
Choose a base branch
from
Open

tests/inst: convert more sh-inline to xshell #3424

samzeter wants to merge 4 commits into from
+139 −120

Conversation

@samzeter
Copy link
Contributor

@samzeter samzeter commented May 20, 2025

Part of #2857

@openshift-ci
Copy link

openshift-ci bot commented May 20, 2025

Hi @samzeter. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@samzeter samzeter force-pushed the sh-inline-to-xshell branch 5 times, most recently from 254fda0 to 384b0e5 Compare May 21, 2025 00:43
@cgwalters
Copy link
Member

cgwalters commented May 22, 2025

Thank you for working on this! Can you rebase on git main to pick up recent CI fixes?

@samzeter samzeter force-pushed the sh-inline-to-xshell branch from 384b0e5 to d9c00b2 Compare May 23, 2025 04:37
@cgwalters
Copy link
Member

cgwalters commented May 23, 2025

Failure in https://github.com/ostreedev/ostree/actions/runs/15202426856/job/42758861826?pr=3424 needs fixing

@champtar
Copy link
Collaborator

champtar commented Aug 20, 2025

@samzeter can you rebase on main / fix the issues ?

@samzeter samzeter force-pushed the sh-inline-to-xshell branch 15 times, most recently from ea87d07 to e07f868 Compare September 18, 2025 15:26
@samzeter samzeter force-pushed the sh-inline-to-xshell branch 4 times, most recently from 89c84e7 to a3123a4 Compare September 24, 2025 14:22
@samzeter samzeter force-pushed the sh-inline-to-xshell branch 11 times, most recently from f58456e to 43ca23f Compare September 29, 2025 13:07
@samzeter samzeter force-pushed the sh-inline-to-xshell branch 3 times, most recently from 3b1c22f to f5fa1cd Compare September 30, 2025 14:25
@samzeter
tests/inst: Remove all instances of sh_inline
0ac5a07 
- Update test helper functions to work with xshell Cmd struct types

- Remove remaining sh_inline commands
@samzeter
Copy link
Contributor Author

samzeter commented Dec 16, 2025

@champtar It should be good for review now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samzeter @cgwalters @champtar