Skip to content

Conversation

@myml
Copy link

@myml myml commented Oct 31, 2025

The current ostree curl fetcher has two issues that prevent proper fallback when using a mirrorlist:

  1. The max_size check does not account for non-2xx responses. When a server returns 3xx, 4xx, or 5xx, the response body may exceed max_size.
  2. Some state variables and temporary files are not reset when falling back to the next mirror.

@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2025

Hi @myml. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses two issues with the curl fetcher's mirror fallback logic. The first change correctly prevents max_size checks from failing on non-2xx HTTP responses, which could have large bodies (e.g., error pages). The second change properly resets request state variables and temporary files before retrying with a new mirror. I have one suggestion to improve the robustness of the state reset logic by adding error handling for file operations.

The current ostree curl fetcher has two issues that prevent proper fallback when using a mirrorlist:
1. The max_size check does not account for non-2xx responses. When a server returns 3xx, 4xx, or 5xx, the response body may exceed max_size.
2. Some state variables and temporary files are not reset when falling back to the next mirror.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant