This repository was archived by the owner on Jan 6, 2023. It is now read-only.
create uefiapp once per image #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating swupd images, all instances of the same base image must share the same uefiapp binary blob and partition settings, because that uefiapp gets copied into each rootfs and should match what's getting installed in the image. But do_uefiapp ran once for each instance of the image recipe (i.e. for ostro-image-swupd, bundle-ostro-image-swupd-mega, etc.) and therefore the (almost) same files were getting created multiple times. In practice, the impact was low because the actual EFI blob always had the same content (only some partition UUIDs varied). This problem was only detected accidentally when writing the output files concurrently into the same location failed. The fix is to create the do_uefiapp task only once and share the results via the deploy directory. uefiapps still need to be created separately for different image recipes because those image recipes may have different parameters for the uefiapp creation (in particular APPEND is meant to be customizable per image recipe). Signed-off-by: Patrick Ohly <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing this, beware that task-depends.dot is incorrect
unless the new "cooker: Fix incorrect dot file generation" fix is
applied to bitbake. But it already works in practise also without
that patch.
@igor-stoppa: please review