This repository was archived by the owner on Jan 6, 2023. It is now read-only.
ostro-image-swupd.bb: install mraa/upm bindings also in swupd images #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image feature check for mraa and upm language bindings did not work for swupd images, because the content of the "world-dev" bundle was based on FEATURE_PACKAGES_ variables and not image features. The result was that FEATURE_PACKAGES_devkit did not include the Java, Python and JavaScript language binding packages and they were not getting installed. Now the content for "world-dev" gets selected both via packages (BUNDLE_CONTENTS_WORLD) and features (BUNDLE_FEATURES_WORLD). This approach is simpler and probably wasn't used from the start because changing bundle features was only added later. Fixes: ostro-os/ostroproject#155 Signed-off-by: Patrick Ohly <[email protected]>
Contributor
|
@pohly would you be able to finish this work (rebase + check the output). The bug is being monitored so I thought we could finish this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beware that I have not completed validating this change. Please check
that resulting images from this PR have the full mraa/upm bindings
installed in ostro-image-swupd-dev.
Fixes: ostro-os/#155
Signed-off-by: Patrick Ohly [email protected]