This repository was archived by the owner on Jan 6, 2023. It is now read-only.
finish meta-swupd enhancements #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having to augment the function from meta-swupd, we can now use the SWUPD_FILE_BLACKLIST mechanism in meta-swupd to exclude undesired filed. This is better because it is simpler and will also work once meta-swupd switches to creating content files instead of individual bundle directories. Signed-off-by: Patrick Ohly <[email protected]>
The updated meta-swupd expects these settings to be for the image(s). Making them in the swupd client is conceptually wrong because different images may need different settings and/or developers may want to change them without recompiling swupd-client. We can set these values at the distro level instead of per-image because of the use of SWUPD_IMAGE_PN, the value is valid for different image recipes. Now that ostro-os has the latest meta-swupd, we can remove the obsolete assignments from the recipe. Signed-off-by: Patrick Ohly <[email protected]>
Contributor
Author
|
@mythi build was fine, okay to merge? This is the last piece of ostroproject/ostro-os#198 which hasn't been merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes obsolete code.