Fix script engine access in XMLHttpRequest #1969
Open
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksuprynowicz
added
bug
Member
|
What does this fix? |
Member
Author
|
It fixes a crash on newest libnode. On release we still have the old libnode. |
ksuprynowicz
added
QA approved
ada-tv
reviewed
Jan 3, 2026
| _v8Object.Reset(); | ||
| QObject* qobject = _object; | ||
| if(qobject) qobject->deleteLater(); | ||
| if(qobject) delete qobject; |
Collaborator
There was a problem hiding this comment.
Maybe add an assertion to check this is running on the right thread?
Member
Author
There was a problem hiding this comment.
Thank you! I added an assert and it uncovered underlying issue with ScriptableResource which I fixed too.
| _qobjectWrapperMap.clear(); | ||
| _qobjectWrapperMapV8.clear(); | ||
| } | ||
| // Events need to be processed one more time: |
Collaborator
There was a problem hiding this comment.
Maybe a comment stating this is for completing pending deleteLater calls?
Collaborator
|
Fixes a crash for me when disconnecting from |
ada-tv
approved these changes
Jan 6, 2026
ada-tv
added
CR approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Gouldron for the backtrace!