Skip to content

Conversation

@JulianGro
Copy link
Member

@JulianGro JulianGro commented Dec 30, 2025

We don't want the code to rot, like OpenGL ES did in the past.

This PR also fixes Windows builds and some warnings.

We don't want the code to rot, like OpenGL ES did in the past.
C:\actions-runner\overte\overte\plugins\oculus\src\OculusDisplayPlugin.cpp(167,20): error C3861: 'getGLBackend': identifier not found [C:\actions-runner\overte\overte\build\plugins\oculus\oculus.vcxproj]   
C:\actions-runner\overte\overte\plugins\oculus\src\OculusDisplayPlugin.cpp(168,35): error C3536: 'fbo': cannot be used before it is initialized [C:\actions-runner\overte\overte\build\plugins\oculus\oculus.vcxproj]
@JulianGro JulianGro marked this pull request as ready for review December 31, 2025 11:23
@JulianGro JulianGro added the needs CR This pull request needs to be code reviewed label Dec 31, 2025
Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Everything looks good :)

@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Jan 3, 2026
@JulianGro JulianGro merged commit 195c020 into overte-org:master Jan 3, 2026
5 checks passed
@JulianGro JulianGro deleted the vulkan_CI branch January 3, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CR approved This pull request has been successfully code reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants