feat(checkbox): add tile variant with associated styling and examples #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellier
requested changes
Dec 22, 2025
Contributor
dpellier
left a comment
dpellier
left a comment
There was a problem hiding this comment.
- feels weird that the card hover effect is triggered when the mouse enter, even on a non clickable part (as in your Variant example, where there is a spacing aroung the clickable part).
- update Demo variant controls with right category and select options
| @@ -1,3 +1,4 @@ | |||
| import { CHECKBOX_VARIANT } from '@ovhcloud/ods-react-checkbox/src/constants/checkbox-variant'; | |||
Contributor
There was a problem hiding this comment.
do not use lib import, if used on Canvas or storybook will display the minified code, import from '../../../../ods-react/src/components/checkbox/src';
|
|
||
| export const Variants: Story = { | ||
| globals: { | ||
| imports: `import { Checkbox, CheckboxControl, CheckboxLabel } from '@ovhcloud/ods-react';`, |
| @@ -0,0 +1,14 @@ | |||
| enum CHECKBOX_VARIANT { | |||
Contributor
There was a problem hiding this comment.
add those to the index.ts export
| background-color: var(--ods-tile-background-color-checked); | ||
| } | ||
|
|
||
| &:has([data-disabled]) { |
Contributor
There was a problem hiding this comment.
did you try all states here?
- disabled + hover
- disabled + checked
- disabled + checked + hover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.