feat(pci-kubernetes): add name section #21291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taelar
force-pushed
the
feat/TAPC-5326-add-cluster-name-step
branch
2 times, most recently
from
97dc0c3 to
1c64569
Compare
Taelar
requested review from
Tsiorifamonjena,
ZyaCon,
aTurmo,
fredericvilcot,
lolottetheclash,
ppprevost and
snigle
github-actions
bot
added
translation required
universe-public-cloud
feature
Taelar
force-pushed
the
feat/TAPC-5326-add-cluster-name-step
branch
from
86f29f2 to
4bbc997
Compare
Taelar
force-pushed
the
feat/TAPC-5326-add-cluster-name-step
branch
from
4bbc997 to
e9dfeae
Compare
lolottetheclash
approved these changes
Dec 29, 2025
Contributor
lolottetheclash
left a comment
lolottetheclash
left a comment
There was a problem hiding this comment.
This generic section is well thought out with the Path here:
type TNameSectionProps<FormSchema extends object> = {
fieldName: Path<FormSchema>;
fieldHelper: string;
};
Well done!
...es/manager/apps/pci-kubernetes/src/pages/new/components/CreateClusterForm.component.spec.tsx
Outdated
Show resolved
Hide resolved
Taelar
force-pushed
the
feat/TAPC-5326-add-cluster-name-step
branch
from
e9dfeae to
c3b02d7
Compare
...manager/apps/pci-kubernetes/src/pages/new_v2/components/CreateClusterForm.component.spec.tsx
Show resolved
Hide resolved
...ager/apps/pci-kubernetes/src/pages/new_v2/hooks/useCreateClusterForm/useCreateClusterForm.ts
Show resolved
Hide resolved
ppprevost
approved these changes
Dec 29, 2025
packages/manager/apps/pci-kubernetes/src/components/create/NameSection.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/pages/new/components/CreateClusterForm.component.tsx
Outdated
Show resolved
Hide resolved
Taelar
force-pushed
the
feat/TAPC-5326-add-cluster-name-step
branch
3 times, most recently
from
d062ce1 to
3140245
Compare
ppprevost
approved these changes
Dec 30, 2025
| <FormFieldHelper className="flex flex-col"> | ||
| {helperEntries.map((entry, index) => ( | ||
| <Text preset="caption" key={index}> | ||
| {entry} |
Tsiorifamonjena
approved these changes
Dec 30, 2025
ppprevost
reviewed
Jan 5, 2026
| </div> | ||
| <FormProvider {...form}> | ||
| <div className="flex flex-col gap-6 md:flex-row"> | ||
| <section className="flex-[2]"> |
| <ClusterNameSection /> | ||
| <Divider spacing={dividerSpacing} /> | ||
| </section> | ||
| <aside className="flex-1"> |
Contributor
Author
There was a problem hiding this comment.
The recommended way is actually to use the flex property rather than just flex-basis (especially cause it also includes a flex-grow property).
Plus I think we should not change our codes out of fear of custom values when Tailwind intentionally lets us decide which value we should use (https://tailwindcss.com/docs/flex) 😅
aTurmo
reviewed
Jan 6, 2026
|
|
||
| export type TCartProps = { | ||
| items: TCartItem[]; | ||
| confirmDisabled: boolean; |
Contributor
There was a problem hiding this comment.
Question: confirmDisabled ? I don't get the name of this props. it suggest an action since confirm is used as an imperative verb. Since it's used to disable a button why not just "isActionDisabled" or something like that ?
ppprevost
reviewed
Jan 6, 2026
| helperEntries: Array<string>; | ||
| }; | ||
|
|
||
| export const NameSection = <FormSchema extends object>({ |
Contributor
There was a problem hiding this comment.
from object to FieldValues
import { FieldValues, Path, useFormContext } from 'react-hook-form';
FormSchema extends FieldValues
ppprevost
force-pushed
the
feat/TAPC-2217-mks-redesign-creation-page
branch
from
1f4ba46 to
a1787eb
Compare
github-actions
bot
added
the
has conflicts
Taelar
force-pushed
the
feat/TAPC-2217-mks-redesign-creation-page
branch
2 times, most recently
from
723d44c to
6042891
Compare
Taelar
force-pushed
the
feat/TAPC-5326-add-cluster-name-step
branch
from
3140245 to
b597434
Compare
github-actions
bot
added
translation required
and removed
has conflicts
ref: #TAPC-5326 Signed-off-by: Thomas Esseul <[email protected]>
Taelar
force-pushed
the
feat/TAPC-5326-add-cluster-name-step
branch
from
b597434 to
170abbe
Compare
aTurmo
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-5326
Description
Ticket Reference: #...
Additional Information