-
Notifications
You must be signed in to change notification settings - Fork 193
OCISDEV-220: run e2e test suites based on the changes in web packages #12865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCISDEV-220: run e2e test suites based on the changes in web packages #12865
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
b945c0b to
3cce412
Compare
5d30d0c to
613f5ad
Compare
e93453e to
9cee5f0
Compare
43a4370 to
4972ebc
Compare
efaf82e to
6f0a98b
Compare
6f0a98b to
bd46766
Compare
|
@saw-jan here's a diagram for the dependencies: graph TD
%% Core Packages
web-client[web-client]
design-system[design-system]
%% Infrastructure Packages
web-pkg[web-pkg]
web-runtime[web-runtime]
%% Application Packages
web-app-activities[web-app-activities]
web-app-admin-settings[web-app-admin-settings]
web-app-app-store[web-app-app-store]
web-app-epub-reader[web-app-epub-reader]
web-app-external[web-app-external]
web-app-files[web-app-files]
web-app-ocm[web-app-ocm]
web-app-password-protected-folders[web-app-password-protected-folders]
web-app-pdf-viewer[web-app-pdf-viewer]
web-app-preview[web-app-preview]
web-app-search[web-app-search]
web-app-text-editor[web-app-text-editor]
web-app-webfinger[web-app-webfinger]
%% Infrastructure Dependencies
web-pkg --> web-client
web-pkg --> design-system
web-runtime --> web-client
web-runtime --> web-pkg
web-runtime --> design-system
%% App Dependencies (with design-system)
web-app-activities --> web-client
web-app-activities --> web-pkg
web-app-activities --> web-runtime
web-app-activities --> design-system
web-app-admin-settings --> web-client
web-app-admin-settings --> web-pkg
web-app-admin-settings --> web-runtime
web-app-admin-settings --> design-system
web-app-app-store --> web-client
web-app-app-store --> web-pkg
web-app-app-store --> web-runtime
web-app-app-store --> design-system
web-app-files --> web-client
web-app-files --> web-pkg
web-app-files --> web-runtime
web-app-files --> design-system
web-app-ocm --> web-client
web-app-ocm --> web-pkg
web-app-ocm --> web-runtime
web-app-ocm --> design-system
web-app-search --> web-client
web-app-search --> web-pkg
web-app-search --> web-runtime
web-app-search --> design-system
web-app-webfinger --> web-client
web-app-webfinger --> web-pkg
web-app-webfinger --> web-runtime
web-app-webfinger --> design-system
%% App Dependencies (without design-system)
web-app-epub-reader --> web-client
web-app-epub-reader --> web-pkg
web-app-epub-reader --> web-runtime
web-app-external --> web-client
web-app-external --> web-pkg
web-app-external --> web-runtime
web-app-password-protected-folders --> web-client
web-app-password-protected-folders --> web-pkg
web-app-password-protected-folders --> web-runtime
web-app-preview --> web-client
web-app-preview --> web-pkg
web-app-preview --> web-runtime
web-app-text-editor --> web-client
web-app-text-editor --> web-pkg
web-app-text-editor --> web-runtime
%% Special case: pdf-viewer doesn't use web-client
web-app-pdf-viewer --> web-pkg
web-app-pdf-viewer --> web-runtime
%% Styling
classDef corePackage fill:#e1f5ff,stroke:#0288d1,stroke-width:3px
classDef infraPackage fill:#fff9c4,stroke:#f57c00,stroke-width:2px
classDef appPackage fill:#f3e5f5,stroke:#7b1fa2,stroke-width:2px
class web-client,design-system corePackage
class web-pkg,web-runtime infraPackage
class web-app-activities,web-app-admin-settings,web-app-app-store,web-app-epub-reader,web-app-external,web-app-files,web-app-ocm,web-app-password-protected-folders,web-app-pdf-viewer,web-app-preview,web-app-search,web-app-text-editor,web-app-webfinger appPackage
|
eafbc35 to
bb60d88
Compare
LukasHirt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saw-jan do you think we should add some information about this into the dev docs?
yeah, would be great. I will add it |
Signed-off-by: Saw-jan <[email protected]>
Signed-off-by: Saw-jan <[email protected]>
Signed-off-by: Saw-jan <[email protected]>
bb60d88 to
bf42a7d
Compare
|
…#12865) * ci: filter test suites to run based on file changes Signed-off-by: Saw-jan <[email protected]> * feat: add package dependency file to each test suite Signed-off-by: Saw-jan <[email protected]> * docs: add docs on using web-packages.txt Signed-off-by: Saw-jan <[email protected]> --------- Signed-off-by: Saw-jan <[email protected]> Co-authored-by: Saw-jan <[email protected]>



Description
The Implementation: each test suite includes
web-packages.txtfile where the dependent web packages are listed.Example:
# web-packages.txt web-app-search web-app-ocmThis list is then used to determine the affected test suite based on the file changes in the web packages.
Behaviour:
web-packages.txtweb-packages.txtfile, then the suite is marked dependent on all web-packagesdesign-system,web-client,web-runtimeandweb-pkgpackages affect all test suitestests/e2e/,tests/drone/,.drone.star,.drone.envandpackage.jsonalso affect all test suitesExample CI build: https://drone.owncloud.com/owncloud/web/56071
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes