Skip to content

Conversation

@liangmiQwQ
Copy link
Contributor

About #14944

Prevents panic by regarding TSEmptyBodyFunctionExpression as expressions

ps:

  • This PR resolve the panic issue, but doesn't include the syntax validation changes, so please don't close the issue if the PR closes
  • This fix doesn't include additional test cases as existing tests keep passing. If the tests are needed, I may need guidance on how to write them (or any document urls).

Thanks ❤️

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Oct 25, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2025

CodSpeed Performance Report

Merging #14945 will not alter performance

Comparing liangmiQwQ:fix/regard-TSEmptyBodyFunctionExpression-as-experssion (15f875d) with main (34fab40)

Summary

✅ 37 untouched

@liangmiQwQ liangmiQwQ marked this pull request as draft October 25, 2025 13:01
@liangmiQwQ liangmiQwQ marked this pull request as ready for review October 25, 2025 13:11
@liangmiQwQ liangmiQwQ force-pushed the fix/regard-TSEmptyBodyFunctionExpression-as-experssion branch from ded44ab to 5499d0f Compare October 26, 2025 02:11
@liangmiQwQ liangmiQwQ force-pushed the fix/regard-TSEmptyBodyFunctionExpression-as-experssion branch from 5499d0f to 15f875d Compare October 27, 2025 10:11
@camc314
Copy link
Contributor

camc314 commented Oct 29, 2025

@liangmiQwQ thanks for working on this. Is this still needed since #14946 got merged?

@liangmiQwQ
Copy link
Contributor Author

Thanks, I'm also not completely sure. The panic caused by const foo = function bar() got fixed by your PR.

I think it depends: if there are other cases that create TSEmptyBodyFunctionExpression and need symbol_id, this PR might help. If not, it can be closed.

And I'm not sure about whether there is anything like it. What do you think?

@camc314 camc314 requested a review from Boshen October 29, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants