Skip to content

Conversation

@TheAlexLichter
Copy link
Member

@TheAlexLichter TheAlexLichter commented Oct 29, 2025

This PR tries to resolve #15042

Code might not be the nicest, feel free to push something more idiomatic!

Copilot AI review requested due to automatic review settings October 29, 2025 01:01
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Oct 29, 2025
@TheAlexLichter TheAlexLichter changed the title feat: warn when rule is overridden without a corresponding plugin. feat(linter): warn when rule is overridden without a corresponding plugin. Oct 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a warning mechanism to alert users when they configure a built-in rule but haven't enabled the corresponding plugin. This helps detect misconfigurations such as configuring "promise/param-names" without enabling the "promise" plugin.

  • Adds an else branch to warn when a configured rule's plugin is not found
  • Provides helpful error messaging suggesting how to enable the missing plugin

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 29, 2025
@TheAlexLichter TheAlexLichter changed the title feat(linter): warn when rule is overridden without a corresponding plugin. feat(linter): warn for overridden rule without enabled plugin Oct 29, 2025
@TheAlexLichter TheAlexLichter marked this pull request as draft October 29, 2025 01:16
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 29, 2025

CodSpeed Performance Report

Merging #15044 will not alter performance

Comparing TheAlexLichter:feat/warn-rule-for-disabled-plugin (9ec2862) with main (561b743)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@TheAlexLichter TheAlexLichter marked this pull request as ready for review October 29, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn when rule for disabled plugin is configured

1 participant