Fix omdb db disks info
#9671
Open
Fix omdb db disks info
#9671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`omdb db disks info` started failing due to a `LookupPath` check preventing the omdb OpContext from looking up arbitrary disks. Fix this by looking up the disk directly in the database in omdb, then splitting the existing `disk_get` into a version that accepts the Disk model directly. Fixes oxidecomputer#9624
hawkw
approved these changes
Jan 20, 2026
Comment on lines
321
to
323
| /// Prefer to use `disk_get` instead: this version of the function bypasses | ||
| /// the LookupPath induced permissions check and is (currently) only called | ||
| /// from omdb. |
Member
There was a problem hiding this comment.
maybe worth explicitly saying that nothing in Nexus should use this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omdb db disks infostarted failing due to aLookupPathcheck preventing the omdb OpContext from looking up arbitrary disks. Fix this by looking up the disk directly in the database in omdb, then splitting the existingdisk_getinto a version that accepts the Disk model directly.Fixes #9624