Fix tosca_book model #37
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RastislavTuranyi
added
bug
New information from books and papers suggests that the delta theta b should indeed be outside the cotangent, though it also suggests that tha alpha2 and alpha3 equations are incorrect. The latter is not addressed here since the correct equations are as of yet unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tosca_bookmodel was previously not working due to two reasons:The former have all been fixed and some of the latter have been corrected, namely:
However, there are more mistakes in the source material that we have not been able to find yet and the value of the neutron mass in the equation has not been established yet (though that should be derivable by fitting once everything else is sorted). Especially, everything about$\Delta \theta_B$ and its use is suspicious.