Skip to content

Conversation

@MonicaRungi-EY
Copy link
Collaborator

Short description

This PR removes the hardcoded AuthSource in favor of retrieving the "Origine dei dati" field from the CredentialsCatalogue.

List of changes proposed in this pull request

  • Removed the hardcoded authSource from the translation JSON
  • Added itwCredentialByTypeSelector to retrieve the correct credential by searching for credentialType
  • Added a utility function mapCredentialsByType to create a key-value map for each credential
  • Added credentialFromCatalogue in ItwIssuanceMetadata
  • Modified getItwAuthSource to retrieve the organization_name field
  • Removed ItwCredentialAuthSource as it is no longer necessary
  • Fixed tests for ItwPresentationClaimsSection

How to test

Enable IT-Wallet, add a credential, navigate to the credential detail, scroll to the bottom and verify that the "Origine dei dati" field is correctly populated.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.20%. Comparing base (b200203) to head (ab4f408).

Files with missing lines Patch % Lines
...features/itwallet/common/utils/itwMetadataUtils.ts 33.33% 2 Missing ⚠️
...itwallet/common/components/ItwIssuanceMetadata.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7652      +/-   ##
==========================================
- Coverage   60.20%   60.20%   -0.01%     
==========================================
  Files        1886     1886              
  Lines       41121    41123       +2     
  Branches     9544     9465      -79     
==========================================
+ Hits        24757    24758       +1     
- Misses      16288    16289       +1     
  Partials       76       76              
Files with missing lines Coverage Δ
ts/features/itwallet/common/utils/itwMocksUtils.ts 100.00% <100.00%> (ø)
...itwallet/common/components/ItwIssuanceMetadata.tsx 75.00% <75.00%> (+0.64%) ⬆️
...features/itwallet/common/utils/itwMetadataUtils.ts 50.00% <33.33%> (-16.67%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b200203...ab4f408. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MonicaRungi-EY MonicaRungi-EY marked this pull request as ready for review November 27, 2025 14:04
@gispada
Copy link
Collaborator

gispada commented Dec 3, 2025

Since the Digital Credentials Catalogue is production ready, we can remove this line. I'd include it in this PR.

);

const authSource =
itwCredential && credentialsFromCatalogue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is correct. Currently itwCredential is true for credentials obtained with L3, so SPID/CieID L2 users won't see the auth source. It should be sufficient to check if the credential type is in the catalogue, or fallback to the old method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants