-
Notifications
You must be signed in to change notification settings - Fork 114
feat(IT Wallet): [SIW-3241] Integration with the credentials catalogue for the field "Origine dei dati" #7652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7652 +/- ##
==========================================
- Coverage 60.20% 60.20% -0.01%
==========================================
Files 1886 1886
Lines 41121 41123 +2
Branches 9544 9465 -79
==========================================
+ Hits 24757 24758 +1
- Misses 16288 16289 +1
Partials 76 76
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ts/features/itwallet/credentialsCatalogue/store/selectors/index.ts
Outdated
Show resolved
Hide resolved
|
Since the Digital Credentials Catalogue is production ready, we can remove this line. I'd include it in this PR. |
| ); | ||
|
|
||
| const authSource = | ||
| itwCredential && credentialsFromCatalogue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this is correct. Currently itwCredential is true for credentials obtained with L3, so SPID/CieID L2 users won't see the auth source. It should be sufficient to check if the credential type is in the catalogue, or fallback to the old method.
Short description
This PR removes the hardcoded
AuthSourcein favor of retrieving the "Origine dei dati" field from theCredentialsCatalogue.List of changes proposed in this pull request
authSourcefrom the translation JSONitwCredentialByTypeSelectorto retrieve the correct credential by searching forcredentialTypemapCredentialsByTypeto create a key-value map for each credentialcredentialFromCatalogueinItwIssuanceMetadatagetItwAuthSourceto retrieve theorganization_namefieldItwCredentialAuthSourceas it is no longer necessaryItwPresentationClaimsSectionHow to test
Enable IT-Wallet, add a credential, navigate to the credential detail, scroll to the bottom and verify that the "Origine dei dati" field is correctly populated.