-
Notifications
You must be signed in to change notification settings - Fork 114
fix: [IOPLT-000] Setup Android screen orientation based on OS version #7658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7658 +/- ##
=======================================
Coverage 60.03% 60.03%
=======================================
Files 1901 1901
Lines 41596 41596
Branches 9664 9664
=======================================
Hits 24974 24974
Misses 16534 16534
Partials 88 88 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Short description
This pull request updates the way screen orientation is handled for the
MainActivityin the Android app. The main change ensures that portrait orientation is explicitly set only for devices running versions earlier than Android Oreo (API 26), instead of enforcing it via the manifest for all versions.Previously the fix was developed here #7628 but was not compatible with Android 8
List of changes proposed in this pull request
android:screenOrientation="portrait"attribute from theMainActivitydeclaration inAndroidManifest, so orientation is no longer forced at the manifest levelMainActivityto programmatically set portrait orientation only for devices running Android versions lower than Oreo (API 26), improving compatibility with newer Android versionsHow to test
Ensure that on Android now the App cannot be in landscape mode and on Android 8 app is not crashing