Skip to content

Conversation

@LeleDallas
Copy link
Contributor

Short description

This pull request updates the way screen orientation is handled for the MainActivity in the Android app. The main change ensures that portrait orientation is explicitly set only for devices running versions earlier than Android Oreo (API 26), instead of enforcing it via the manifest for all versions.

Previously the fix was developed here #7628 but was not compatible with Android 8

List of changes proposed in this pull request

  • Removed the android:screenOrientation="portrait" attribute from the MainActivity declaration in AndroidManifest, so orientation is no longer forced at the manifest level
  • Added a conditional statement in MainActivity to programmatically set portrait orientation only for devices running Android versions lower than Oreo (API 26), improving compatibility with newer Android versions

How to test

Ensure that on Android now the App cannot be in landscape mode and on Android 8 app is not crashing

@github-actions
Copy link
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.03%. Comparing base (0b66ec7) to head (716a7ea).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7658   +/-   ##
=======================================
  Coverage   60.03%   60.03%           
=======================================
  Files        1901     1901           
  Lines       41596    41596           
  Branches     9664     9664           
=======================================
  Hits        24974    24974           
  Misses      16534    16534           
  Partials       88       88           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b66ec7...716a7ea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants