Initial commit #107
Open
Initial commit #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjreich
reviewed
Jul 2, 2018
letsdrill.rb
Outdated
| else | ||
| letter_grade = "F" | ||
| end | ||
| return letter_grade |
There was a problem hiding this comment.
The return keyword is optional in ruby, and the standard is to omit it. If you did that here, can you see how you could also get rid of the letter_grade variable?
letsdrill.rb
Outdated
| end | ||
|
|
||
| def shortest_string(array) | ||
| return the_shortest_string = array.min_by{|a| a.size} |
There was a problem hiding this comment.
Similar comments to the above apply here to. But nice use of min_by!
mikegee
reviewed
Jul 2, 2018
letsdrill.rb
Outdated
| elsif integer >= 60 | ||
| letter_grade = "D" | ||
| else | ||
| letter_grade = "F" |
There was a problem hiding this comment.
The whole if/elsif/else structure evaluates to the value of whichever branch it takes. So, you could move the local variable assignment out of each condition like so:
letter_grade = if integer >= 90
"A"
elsif ...
|
I didn't see Joe's comment until I submitted mine. 😄 Put our comments together and get some amazing Rubby codez! |
|
Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.