Initial commit, with a first pass at implementing the get_letter_grad… #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and shortest_string functions.
jaybobo
reviewed
Mar 16, 2018
| #Put your code here! | ||
|
|
||
| if array.any? | ||
| array.sort_by{|s| s.length}[0] |
There was a problem hiding this comment.
Looks good. .min_by is also an option.
https://ruby-doc.org/core-2.5.0/Enumerable.html#method-i-min_by
jaybobo
reviewed
Mar 16, 2018
There was a problem hiding this comment.
LGTM. .min_by is also an option.
https://ruby-doc.org/core-2.5.0/Enumerable.html#method-i-min_by
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e and shortest_string functions.
Please review @jaybobo.