Pass tests. #102
Open
Pass tests. #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybobo
reviewed
May 10, 2018
|
|
||
| def fetch_CD_animals(input) | ||
| #implement your solution here | ||
| input.find_all do |animal| |
There was a problem hiding this comment.
cool. you can also use .grep which takes a regex pattern. it's super handy.
https://ruby-doc.org/core-2.5.0/Enumerable.html#method-i-grep
|
|
||
| def no_dogs_allowed(input) | ||
| #implement your solution here | ||
| input.reject do |animal| |
There was a problem hiding this comment.
nice. in most cases, we'd write this input.reject { |animal| animal == "dog" }. same with .select above.
|
|
||
| def capitalize_each_string(input) | ||
| #implement your solution here | ||
| input.collect do |word| |
There was a problem hiding this comment.
nice use of collect which is an alias for .map.
you could also write this input.map(&:capitalize) or input.map {|s| s.capitalize}.
be sure to take a look at the Symbol#to_proc method. it's very common.
https://ruby-doc.org/core-1.9.3/Symbol.html#method-i-to_proc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo