Skip to content

Alex richards solution #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Alex richards solution #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfad897
Finished capitalize each string
Jul 2, 2018
6a731f5
Finished all of them.
Jul 3, 2018
4d037b2
I like the .first method. And I would have much rather used the selec…
Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions challenge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,25 @@

def capitalize_each_string(input)
#implement your solution here
input.map{ |x| x.capitalize}
end

def fetch_the_dog(input)
#implement your solution here
input.reject { |e| e != "dog" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this returns an array with one element (the "dog"), but I wouldn't expect the result to be an array.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I was wrong. Ignore that ^

Completely different nitpick: reject and != are both "negative" in a sense, making this a double negative in my opinion. Can this be rephrased positively?

end

def no_dogs_allowed(input)
#implement your solution here
end
input.reject { |e| e == "dog" }end

def count_the_animals(input)
#implement your solution here
input.size
end

def fetch_the_first_two(input)
#implement your solution here
input.first(2)
end

def fetch_CD_animals(input)
#implement your solution here
input.select { |e| e[/\b[cd]/]}
end

## DO NOT CHANGE CODE BELOW THIS LINE ##
Expand All @@ -29,7 +28,7 @@ def fetch_CD_animals(input)

p capitalize_each_string(animals) == ["Cat", "Moose", "Dog", "Bird"]

p fetch_the_dog(animals) == ["dog"]
p fetch_the_dog(animals) == ["dog"]

p no_dogs_allowed(animals) == ["cat", "moose", "bird"]

Expand Down