Skip to content

fix clippy lints #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix clippy lints #473

wants to merge 2 commits into from

Conversation

@tdyas
Copy link
Contributor

@tdyas tdyas commented Jun 19, 2025 •
edited
Loading

Fix some existing clippy lints.

@tdyas tdyas requested review from benjyw and sureshjoshi June 19, 2025 21:03
@tdyas tdyas changed the title fix clippy lints and force them to be errors fix clippy lints Jun 19, 2025
@tdyas
Copy link
Contributor Author

tdyas commented Jun 19, 2025

I tried to use #![deny(warnings)] to force errors but differences in Windows vs UNIX cfg-wrapped code adds some complexity. So just going to fix the existing lints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sureshjoshi sureshjoshi Awaiting requested review from sureshjoshi

@benjyw benjyw Awaiting requested review from benjyw

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tdyas