merge (insted of replace) URLs specified via PANTS_BOOTSTRAP_URLS
#474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
force-pushed
the
tdyas/merge_urls_path_files
branch
from
bcbba7c to
966006c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can use
PANTS_BOOTSTRAP_URLSto add custom versions of Pants to those known byscie-pants. To do so, however, users must provide all of the existingptexkeys obtained viaSCIE=inspect pants | jq .ptexfor each supported platform since specifyingPANTS_BOOTSTRAP_URLSreplaces all existing URLs. Only then can the user supplement the URLs with their own. (The "built-in" URLs are for Python Build Standalone releases known toscie-pants.)This is unwieldy especially if the user does not have access to all of the supported platforms.
scie-pantsshould instead just merge the configuration provided viaPANTS_BOOTSTRAP_URLS. This should be a more intuitive behavior for users. Also, if users did wish to replace the existing ptex URLs for PBS Pythons, the merged configuration will override built-in URLs with the user's URLs if there is a conflict.)