Fixes building documentation for Docs.rs #597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
requested review from
Firstyear,
hug-dev,
ionut-arm and
wiktor-k
Superhepper
force-pushed
the
Docs-Rs-Ci
branch
2 times, most recently
from
80716d9 to
7fe92fd
Compare
wiktor-k
requested changes
Nov 18, 2025
Collaborator
wiktor-k
left a comment
wiktor-k
left a comment
There was a problem hiding this comment.
Good idea 👌
Btw, this is not critical but instead of a commit with N number of bulleted points I usually create N commits, each for each point.
Thanks for this change, it'll be great to have that before the next release! 👋
Building the Docs.rs documentation failed due to a version environmental variable not being set. This commit addresses the problem by defaulting to the minimum supported tpm2-tss version when building for the Docs.rs build. Signed-off-by: Jesper Brynolf <[email protected]>
Superhepper
force-pushed
the
Docs-Rs-Ci
branch
2 times, most recently
from
d631144 to
b2a14ab
Compare
Adds CI check that attempts to replicate how the documentation is built for Docs.rs. Signed-off-by: Jesper Brynolf <[email protected]>
Superhepper
force-pushed
the
Docs-Rs-Ci
branch
from
b2a14ab to
4f9242c
Compare
wiktor-k
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CI test for that is supposed to mimic how the documentation is being built when a new release of the crate is released.
Fixes problem with building the documentation when releasing the crate.