Fix hardhat evm_* helpers to accept integers #10345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests from dragonswap-farming send requests with a 0-second time increase, which is allowed by other implementations. 'param seconds — Number of seconds to jump forward in time. Must be greater than or equal to 0.'
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bee344
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardhat RPC time/gas helpers now accept plain JSON integers, eliminating the
Invalid paramserrors when interacting via Hardhat.Previously, these endpoints only accepted hex strings, so any integer input caused hardhat tests to fail.
This impacts all hardhat tests in
scc-testingusing the following helper functions:evm_mineevm_increaseTimeevm_setNextBlockTimestampevm_setBlockGasLimit