feat(Onboarding): Add modal #732
Conversation
|
Preview: https://chatbot-pr-chatbot-732.surge.sh A11y report: https://chatbot-pr-chatbot-732-a11y.surge.sh |
rebeccaalpert
force-pushed
the
onboarding
branch
from
bb2dac9 to
18e21e3
Compare
rebeccaalpert
force-pushed
the
onboarding
branch
from
61a9be8 to
cf0222e
Compare
|
high contrast looks good on these! |
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
just a microcopy suggestion - the example docs lgtm!
I'm also wondering about the placement of the examples. Do you think these might make sense under the Modals section? If so, maybe the terms of use and settings examples could also belong in there? Not sure how developers actually go about using the docs, but I personally feel like I wouldn't look for this under Navigation 🤔
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/CompactOnboarding.tsx
Outdated
Show resolved
Hide resolved
rebeccaalpert
force-pushed
the
onboarding
branch
from
524db26 to
2213443
Compare
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/CompactOnboarding.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/CompactOnboarding.tsx
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/CompactOnboarding.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/CompactOnboarding.tsx
Outdated
Show resolved
Hide resolved
| /** Optional image displayed in header */ | ||
| image?: string; | ||
| /** Alt text for optional image displayed in header */ | ||
| altText?: string; |
There was a problem hiding this comment.
| /** Optional image displayed in header */ | |
| image?: string; | |
| /** Alt text for optional image displayed in header */ | |
| altText?: string; | |
| /** Optional image displayed in header */ | |
| headerImage?: string; | |
| /** Alt text for optional image displayed in header */ | |
| headerImageAltText?: string; |
There was a problem hiding this comment.
Happy to do this, but does differ from API used in terms and conditions et al.
There was a problem hiding this comment.
I'm good keeping them as-is, just wasn't sure if we'd ever need to differentiate in the future (probably not but I'm sure weirder things have happened)
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/Onboarding.tsx
Outdated
Show resolved
Hide resolved
rebeccaalpert
force-pushed
the
onboarding
branch
3 times, most recently
from
f0f4d8c to
c1b1475
Compare
…mples/UI/CompactOnboarding.tsx Co-authored-by: Erin Donehoo <[email protected]>
rebeccaalpert
force-pushed
the
onboarding
branch
from
c1b1475 to
48d68d2
Compare
|
🎉 This PR is included in version 6.5.0-prerelease.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 participants
Will add screenshots once it passes design review.
Adjusted the spacing a little bit after talking to Kayla since the modal heights can get really big and stretch things out - keeping terms and conditions-style spacing for now.
Demos: