Skip to content

Conversation

@rebeccaalpert
Copy link
Member

@rebeccaalpert rebeccaalpert commented Oct 27, 2025

@rebeccaalpert rebeccaalpert linked an issue Oct 27, 2025 that may be closed by this pull request
@patternfly-build
Copy link

patternfly-build commented Oct 27, 2025

@rebeccaalpert rebeccaalpert marked this pull request as ready for review October 27, 2025 18:28
Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rebeccaalpert
Copy link
Member Author

Added tokens per feedback; let me know if you want other changes here!

@srambach
Copy link
Member

Code looks good - just want to check with @lboehling that the border shouldn't increase to 2 when hovering in HC?

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, likewise to above would want to know if the MessageBar looks fine @lboehling when the hasAiIndicator prop is passed in (the one that gives the MessageBar the nifty gradient border)

Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call @srambach, the border should increase to 2px on hover, 3px on click. Using the border--width--control--hover and border--width--control--clicked tokens for those states should give the appropriate border widths when high contrast is enabled.

@lboehling lboehling self-requested a review November 14, 2025 20:58
Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@rebeccaalpert rebeccaalpert merged commit 8ff9f3f into patternfly:main Nov 14, 2025
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.5.0-prerelease.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message bar high contrast

5 participants