-
Notifications
You must be signed in to change notification settings - Fork 34
feat(MessageBar): Add support for high contrast #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://chatbot-pr-chatbot-734.surge.sh A11y report: https://chatbot-pr-chatbot-734-a11y.surge.sh |
6ff5b87 to
0638064
Compare
lboehling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
lboehling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
0638064 to
340b4a0
Compare
|
Added tokens per feedback; let me know if you want other changes here! |
|
Code looks good - just want to check with @lboehling that the border shouldn't increase to 2 when hovering in HC? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, likewise to above would want to know if the MessageBar looks fine @lboehling when the hasAiIndicator prop is passed in (the one that gives the MessageBar the nifty gradient border)
lboehling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call @srambach, the border should increase to 2px on hover, 3px on click. Using the border--width--control--hover and border--width--control--clicked tokens for those states should give the appropriate border widths when high contrast is enabled.
lboehling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved!
|
🎉 This PR is included in version 6.5.0-prerelease.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Demo: https://chatbot-pr-chatbot-734.surge.sh/patternfly-ai/chatbot/ui#message-bar-with-speech-recognition-and-file-attachment