Skip to content

Conversation

@ochosi
Copy link

@ochosi ochosi commented Dec 10, 2025

Update logic to focus on the first visible sub-step when navigating from a parent step.

What: Fixes #12165

Additional issues:

@patternfly-build
Copy link
Collaborator

patternfly-build commented Dec 10, 2025

@nicolethoen nicolethoen requested a review from kmcfaul December 11, 2025 13:18
@nicolethoen
Copy link
Contributor

@ochosi it looks like there is a linting error that needs to be resolved:

/home/runner/work/patternfly-react/patternfly-react/packages/react-core/src/components/Wizard/WizardNavInternal.tsx
Error:   51:64  error  'subStepIndex' is defined but never used. Allowed unused args must match /^_/u  @typescript-eslint/no-unused-vars

@nicolethoen nicolethoen self-requested a review December 11, 2025 13:35
Update logic to focus on the first visible sub-step when navigating
from a parent step.
@ochosi ochosi force-pushed the fix-wizard-hidden-active-step branch from df9d575 to 02ef4b0 Compare December 11, 2025 14:29
@ochosi
Copy link
Author

ochosi commented Dec 11, 2025

@nicolethoen Thanks for the swift review, and apologies for not noticing the linting error. I guess it'd be convenient if the linter would run on all PRs (for everyone not reading the project's README and using yarn lint:all 😇 )

The linting error is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Wizard - Clicking on parent step crashes when first sub-step is hidden

3 participants