[Migrated from ohttp-relay] - Dockerfile ohttp relay#1244
Draft
benalleng wants to merge 5 commits intopayjoin:masterfrom
Draft
[Migrated from ohttp-relay] - Dockerfile ohttp relay#1244benalleng wants to merge 5 commits intopayjoin:masterfrom
benalleng wants to merge 5 commits intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 20395401893Details
💛 - Coveralls |
nothingmuch
reviewed
Dec 20, 2025
| RUN nix \ | ||
| --extra-experimental-features "nix-command flakes" \ | ||
| --option filter-syscalls false \ | ||
| build |
Collaborator
There was a problem hiding this comment.
i don't think this will work, COPY . /tmp/build will only copy the ohttp-relay subdirectory. if the root was copied, there's no default package defined, so at the very least we need to build like this:
Suggested change
| build .#ohttp-relay |
if we take the Dockerfile route, but i think it's much easier to use https://github.com/nlewo/nix2container which has the same effect as this dockerfile except the image is constructed directly from a nix derivation, and you can just nix build .#ohttp-relay.dockerImage
regardless, mainly in order to note this down somewhere linked, this will currently ship a release binary but if #1228 is merged it will start shipping debug builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally opened in payjoin/ohttp-relay#49
Feel free to take or leave anything you like here, but wanted to push upstream some minor optimizations to the Dockerfile along with an easy way to get automatic Docker image builds via Github Actions, for both amd64 and arm64.
The main part you may not want is pinning Docker images to releases/tags as I've done here, if not I'm happy to modify the PR to remove that aspect, but I personally like that for two reasons:
More detailed discussion is listed in the original repo.
v0.0.9
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.