Add library package to have missing packages available at runtime#1281
Open
benalleng wants to merge 1 commit intopayjoin:masterfrom
Open
Add library package to have missing packages available at runtime#1281benalleng wants to merge 1 commit intopayjoin:masterfrom
benalleng wants to merge 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 21213285933Details
💛 - Coveralls |
benalleng
changed the title
benalleng
changed the title
benalleng
changed the title
benalleng
changed the title
There has been a regression where corepc-node needs libbz2.so.1.0 but it is not compiled at runtime. This commit adds bzip2 to the package list to allow corepc-node to compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a regression where corepc-node needs libbz2.so.1.0 but it is not compiled at runtime. This commit explicitly adds bzip2 to the package list to allow corepc-node to compile.
This regression is not easily reproduce-able as it is not happening in all environments.
Chatgpt read through the cranelib docs to show me where to put this instead of alongside packages as a LD_LIBRARY_PATH which accomplishes the same thing but I think the syntax of just adding it to the package list instead of a library path env variable is simple enough still.I ended up not using this approachPull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.