Rename crane profile to nix-ci and use for checks#1297
Open
Mshehu5 wants to merge 1 commit intopayjoin:masterfrom
Open
Rename crane profile to nix-ci and use for checks#1297Mshehu5 wants to merge 1 commit intopayjoin:masterfrom
Mshehu5 wants to merge 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 21332553079Details
💛 - Coveralls |
nothingmuch
approved these changes
Jan 25, 2026
Collaborator
nothingmuch
left a comment
nothingmuch
left a comment
There was a problem hiding this comment.
utACK, my suggestion is optional but maybe would help to simplify a little
flake.nix
Outdated
| "ohttp-relay" = ""; | ||
| "payjoin-service" = ""; | ||
| }; | ||
| # use nix-ci profile for packages |
Collaborator
There was a problem hiding this comment.
i would consider moving this whole block to where it is used and eliminate the variable, it makes sense to define it as a transformation of the packages in the context of defining the msrv check suite, and remove the merging of ciPackages into the top level checks (under the msrv check is enough as nix flake check with no arguments will run that too)
Rename [profile.crane] to [profile.nix-ci] in Cargo.toml for clarity. Separate build configurations into ciArgs for fast checks builds and releaseArgs for production build. Packages now use release profile by default while checks use nix-ci profile via ciPackages override. Add separate cargoArtifactsCi to cache CI-profile dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #1290
As stated in the issue this PR renames [profile.crane] to [profile.nix-ci] in Cargo.toml for clarity.
ciArgs,cargoArtifactsCi where added they use nix-ci profile for checks which are used in CI so they are fast
releaseArgs which use release profile is added so build packages are highly optimized and ready for production use.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.