feat: implement ohttp gateway middleware#1306
Open
Harshdev098 wants to merge 1 commit intopayjoin:masterfrom
Open
feat: implement ohttp gateway middleware#1306Harshdev098 wants to merge 1 commit intopayjoin:masterfrom
Harshdev098 wants to merge 1 commit intopayjoin:masterfrom
Conversation
Signed-off-by: Harsh Dev Pathak <[email protected]>
Collaborator
|
ThankS for working on this @Harshdev098. Ideally we would want this middleware to be written with axum so it would fit in with the rest of the middlwares we plan to add, @spacebear21 this is correct right ? |
Collaborator
Yes exactly. The gateway should be an axum middleware written mostly from scratch similar to @zealsham's ongoing work in #1296. Duplication could also be reduced by first making the helper utils ( |
Contributor
Author
|
okay will use axum in the middleware and update you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #941
added ohttp gateway middleware in payjoin-services.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.