Skip to content

Fix metrics spawn in serve_acme#1317

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:fix-service-acme-metrics
Feb 5, 2026
Merged

Fix metrics spawn in serve_acme#1317
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:fix-service-acme-metrics

Conversation

@spacebear21
Copy link
Collaborator

In my rebase I forgot to spawn the metrics server in serve_acme.

Pull Request Checklist

Please confirm the following before requesting review:

In my rebase I forgot to spawn the metrics server in serve_acme.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 21720901000

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 83.263%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-service/src/lib.rs 0 3 0.0%
Totals Coverage Status
Change from base Build 21720184564: -0.01%
Covered Lines: 10238
Relevant Lines: 12296

💛 - Coveralls

Copy link
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9510b5

@spacebear21 spacebear21 merged commit 2402f37 into payjoin:master Feb 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants