Replace current panel log viewer with new and improved log viewer #1834
Conversation
📝 WalkthroughWalkthroughReplaces AchyutN log viewer with Boquizo plugin, adds new Filament admin pages ListLogs and ViewLogs (with log upload/download/delete actions), adds upload-to-external-service workflow, new translations, a Blade list-logs view, CSS template scanning directive, and updates composer dependency and post-install script. Changes
Sequence Diagram(s)sequenceDiagram
participant Admin as Admin UI (Filament)
participant View as ViewLogs/ListLogs Page
participant Storage as Local Storage (storage/logs)
participant HTTP as logs.pelican.dev (HTTP API)
participant Browser as User Browser
Note over Admin,View: User triggers "Upload Logs" action (button/modal)
Browser->>View: confirm upload (modal)
View->>Storage: check file exists
alt file not found
View-->>Browser: show danger notification "log_not_found"
else file found
View->>Storage: read last ≤1000 lines
View->>HTTP: multipart POST (field c => content, e => 14d)
alt HTTP failure (non-2xx)
HTTP-->>View: non-2xx status
View-->>Browser: show danger notification with status
else HTTP success (2xx + JSON)
HTTP-->>View: JSON { url: "<uploaded_url>" }
View-->>Browser: show persistent success notification with URL and "View Logs" action
Browser->>Browser: user clicks "View Logs" -> opens URL in new tab
end
end
Note right of View: exceptions caught -> danger notification with message
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi gboquizosanchez here. I came from here -> gboquizosanchez/filament-log-viewer#36 I have just commented it's necessary in certain plugins to establish a custom theme in Filament v4 because of the new version of the tailwindCSS v4.
@import '../../../../vendor/filament/filament/resources/css/theme.css';
@source '../../../../app/Filament/**/*';
@source '../../../../resources/views/filament/**/*';
@source '../../../../vendor/gboquizosanchez/filament-log-viewer/resources/views/**/*.blade.php';
EDIT: I have just tested into your application and you just add into app.css file:
All will work properly: 
I hope those lines can be helpful. If not, I'll glad to help you'all in the way I can. Cheers! |
Thanks! i just tested it <3 |
|
Guess we have to update the workflow matrix :') |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
composer.json (1)
6-6: CRITICAL: PHP 8.2 constraint still present despite PR title.The PR title states "Remove php 8.2 support" and comments indicate the new log viewer plugin requires PHP 8.3+, but the constraint still allows
^8.2.Apply this diff to enforce PHP 8.3 minimum:
- "php": "^8.2 || ^8.3 || ^8.4", + "php": "^8.3 || ^8.4",Also update the platform constraint:
"platform": { - "php": "8.2" + "php": "8.3" }
♻️ Duplicate comments (1)
resources/views/filament/components/view-log.blade.php (1)
1-3: Verify if this view is actually referenced.The
ViewLogsclass doesn't define a$viewproperty, so it will use the default view fromBaseViewLog. This custom view may be unused unless explicitly configured elsewhere.Run the following script to check if this view is referenced:
#!/bin/bash # Check if view-log.blade.php is referenced anywhere in the codebase rg -n "view-log|viewLog" --type=php -C2
🧹 Nitpick comments (4)
composer.json (1)
84-85: Post-install script could be more robust.The
strposcheck will match commented lines or partial matches. Consider using a more precise regex pattern to detect the actual key.- "php -r \"$env = file_get_contents('.env'); if (strpos($env, 'FILAMENT_LOG_VIEWER_DRIVER=') === false) { file_put_contents('.env', rtrim($env) . PHP_EOL . 'FILAMENT_LOG_VIEWER_DRIVER=raw' . PHP_EOL); }\"" + "php -r \"$env = file_get_contents('.env'); if (!preg_match('/^\\s*FILAMENT_LOG_VIEWER_DRIVER\\s*=/m', $env)) { file_put_contents('.env', rtrim($env) . PHP_EOL . 'FILAMENT_LOG_VIEWER_DRIVER=raw' . PHP_EOL); }\""app/Filament/Admin/Pages/ViewLogs.php (1)
23-97: Extract duplicated upload logic to a shared service.The upload action logic (lines 31-96) is duplicated between
ViewLogsandListLogs. Consider extracting this to a dedicated service class or trait.Create a new service class:
namespace App\Services; use Filament\Notifications\Notification; use Illuminate\Support\Facades\Http; class LogUploadService { public static function upload(string $logDate): ?string { $logPath = storage_path('logs/' . $logDate); if (!file_exists($logPath)) { Notification::make() ->title(trans('admin/log.actions.log_not_found')) ->body(trans('admin/log.actions.log_not_found_description', ['filename' => $logDate])) ->danger() ->send(); return null; } $lines = file($logPath, FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES); $totalLines = count($lines); $uploadLines = $totalLines <= 1000 ? $lines : array_slice($lines, -1000); $content = implode("\n", $uploadLines); try { $response = Http::asMultipart()->post('https://logs.pelican.dev', [ ['name' => 'c', 'contents' => $content], ['name' => 'e', 'contents' => '14d'], ]); if ($response->failed()) { Notification::make() ->title(trans('admin/log.actions.failed_to_upload')) ->body(trans('admin/log.actions.failed_to_upload_description', ['status' => $response->status()])) ->danger() ->send(); return null; } $data = $response->json(); return $data['url'] ?? null; } catch (\Exception $e) { Notification::make() ->title(trans('admin/log.actions.failed_to_upload')) ->body($e->getMessage()) ->danger() ->send(); return null; } } }Then use it in both classes:
->action(function () { $url = LogUploadService::upload($this->record->date); if ($url) { Notification::make() ->title(trans('admin/log.actions.log_upload')) ->body($url) ->success() ->actions([ Action::make('viewLogs') ->label(trans('admin/log.actions.view_logs')) ->url($url) ->openUrlInNewTab(true), ]) ->persistent() ->send(); } })app/Filament/Admin/Pages/ListLogs.php (2)
46-52: Extract hardcoded URL to a constant.The URL
https://logs.pelican.devis duplicated on lines 52 and 71. Consider extracting it to a class constant or configuration value for easier maintenance.Apply this diff to add a constant at the class level:
class ListLogs extends BaseListLogs { protected string $view = 'filament.components.list-logs'; + private const LOGS_SERVICE_URL = 'https://logs.pelican.dev';Then update line 52:
- ->modalDescription(fn ($record) => trans('admin/log.actions.upload_logs_description', ['file' => $record['date'], 'url' => 'https://logs.pelican.dev'])) + ->modalDescription(fn ($record) => trans('admin/log.actions.upload_logs_description', ['file' => $record['date'], 'url' => self::LOGS_SERVICE_URL]))And line 71:
- $hbUrl = 'https://logs.pelican.dev'; + $hbUrl = self::LOGS_SERVICE_URL;
80-80: Consider making expiration configurable.The expiration value
'14d'is hardcoded. Depending on your use case, you might want to make this configurable through settings or environment variables.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (9)
app/Filament/Admin/Pages/ListLogs.php(1 hunks)app/Filament/Admin/Pages/ViewLogs.php(1 hunks)app/Providers/Filament/AdminPanelProvider.php(2 hunks)app/Providers/Filament/AppPanelProvider.php(2 hunks)composer.json(2 hunks)lang/en/admin/log.php(1 hunks)resources/css/app.css(1 hunks)resources/views/filament/components/list-logs.blade.php(1 hunks)resources/views/filament/components/view-log.blade.php(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-05T22:21:31.863Z
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1865
File: app/Filament/Admin/Resources/Nodes/Pages/EditNode.php:682-682
Timestamp: 2025-11-05T22:21:31.863Z
Learning: In app/Filament/Admin/Resources/Nodes/Pages/EditNode.php, the diagnostics tab's upload action intentionally does not use the iconButton() modifier, while the pull action does. This UI difference is intentional.
Applied to files:
app/Filament/Admin/Pages/ViewLogs.php
🧬 Code graph analysis (1)
app/Providers/Filament/AdminPanelProvider.php (4)
app/Filament/Admin/Pages/ListLogs.php (1)
ListLogs(18-124)app/Filament/Admin/Pages/ViewLogs.php (1)
ViewLogs(14-102)app/helpers.php (1)
user(127-130)app/Models/User.php (1)
can(358-371)
🔇 Additional comments (10)
resources/css/app.css (1)
27-27: LGTM! Resolves the white-on-white text issue.This @source directive ensures Tailwind v4 scans the new log viewer templates, fixing the unreadable email preview text reported in issue #1802.
resources/views/filament/components/list-logs.blade.php (1)
1-3: LGTM!Standard Filament page wrapper pattern, correctly referenced by the
ListLogspage class.app/Providers/Filament/AppPanelProvider.php (1)
5-5: LGTM! Clean migration to the new log viewer package.The namespace and class changes align with the dependency update in composer.json.
Also applies to: 29-29
app/Providers/Filament/AdminPanelProvider.php (1)
5-7: LGTM! Well-structured plugin configuration.The migration to the new log viewer plugin is clean, with proper wiring of custom page classes and translations.
Also applies to: 40-46
app/Filament/Admin/Pages/ListLogs.php (6)
1-20: LGTM!The namespace, imports, and class structure are well-organized and appropriate for the functionality being implemented.
22-25: LGTM!The heading method correctly returns a translated string with appropriate type hints.
27-40: LGTM!The table configuration and column definitions are appropriate for displaying log file information with multiple severity levels.
42-45: LGTM!The view and download actions are properly configured with appropriate icons.
53-64: LGTM!The file existence validation is properly implemented with appropriate user feedback.
120-122: LGTM!The delete action is properly configured with an appropriate icon.
notAreYouScared
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
app/Filament/Admin/Pages/ListLogs.php (1)
100-101: Validate response structure before accessing the URL key.The code directly accesses
$data['url']without validating the response structure. Thejson()method can returnnull, an array, or astdClassobject. Boy132 confirmed in ViewLogs.php that this pattern throws "Cannot use object of type stdClass as array" when the response is a JSON object.Apply this diff to add validation:
$data = $response->json(); + + if (!is_array($data) || !isset($data['url'])) { + Notification::make() + ->title(trans('admin/log.actions.failed_to_upload')) + ->body(trans('admin/log.actions.invalid_response')) + ->danger() + ->send(); + + return; + } + $url = $data['url'];Ensure the translation key
admin/log.actions.invalid_responseexists in your language file.app/Filament/Admin/Pages/ViewLogs.php (1)
72-73: Fix confirmed runtime error: validate response structure before array access.Boy132 confirmed this code throws "Cannot use object of type stdClass as array" when viewing a log. The
json()method returns astdClassobject when the response is a JSON object, but the code attempts array access with$data['url'].Apply this diff to fix the error:
$data = $response->json(); + + if (!is_array($data) || !isset($data['url'])) { + Notification::make() + ->title(trans('admin/log.actions.failed_to_upload')) + ->body(trans('admin/log.actions.invalid_response')) + ->danger() + ->send(); + + return; + } + $url = $data['url'];Ensure the translation key
admin/log.actions.invalid_responseexists in your language file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
app/Filament/Admin/Pages/ListLogs.php(1 hunks)app/Filament/Admin/Pages/ViewLogs.php(1 hunks)lang/en/admin/log.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- lang/en/admin/log.php
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-05T22:21:31.863Z
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1865
File: app/Filament/Admin/Resources/Nodes/Pages/EditNode.php:682-682
Timestamp: 2025-11-05T22:21:31.863Z
Learning: In app/Filament/Admin/Resources/Nodes/Pages/EditNode.php, the diagnostics tab's upload action intentionally does not use the iconButton() modifier, while the pull action does. This UI difference is intentional.
Applied to files:
app/Filament/Admin/Pages/ViewLogs.php
Closes #1802
Replaces current error log manager with a new one, tested with a 10MB error log file that was 49,000 lines long. Loading time was 0.38 seconds
Actions are View, Download, Upload(to logs.pelican.dev), and delete.
Actions are delete, download, upload, back
Stacktrace:
