[FEATURE] Prometheus: support query params #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine THEBAUD <[email protected]>
Signed-off-by: Antoine THEBAUD <[email protected]>
AntoineThebaud
changed the title
Signed-off-by: Antoine THEBAUD <[email protected]>
AntoineThebaud
force-pushed
the
antoinethebaud/prom-query-params
branch
from
83e646b to
f0b6d9a
Compare
Signed-off-by: Antoine THEBAUD <[email protected]>
AntoineThebaud
changed the title
shahrokni
reviewed
Nov 28, 2025
shahrokni
reviewed
Nov 28, 2025
6 tasks
- dont save empty keys - avoid using index as key for loop-generated components - remove useless check Signed-off-by: Antoine THEBAUD <[email protected]>
shahrokni
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes perses/perses#1523.
Closes perses/perses#3509 (
enginequery param can be passed).I guess this piece of code could be moved to plugin-system in the future if other datasources start to support query params. Since it's Prometheus only for now I prefer to have it here.
Screenshots
New section at the end of the datasource editor:
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes