Add more intuitive arguments to default.launch #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amalnanavati
approved these changes
Aug 31, 2021
Contributor
amalnanavati
left a comment
amalnanavati
left a comment
There was a problem hiding this comment.
LGTM. I'm approving because the comments are either minor or just clarifying comments. If you end up addressing the minor comment I'll re-approve, but I also think it's fine to merge it in as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Add all controllers from personalrobotics/pr_ros_controllers#26 to YAML file for use.
(2) Modify default.launch to be sensitive to arm version and DOF. In preparation for making the repo more robot-agnostic.
Note: this should not change any functionality as-is. It is mostly a refactor in preparation for future PRs.
Before creating a pull request
make formatBefore merging a pull request