Skip to content

perspective-workspace: safer isVisible() callbacks #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

perspective-workspace: safer isVisible() callbacks #3076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/workspace/src/ts/workspace/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,9 @@ export const createCommands = (
isVisible: (args) => {
const target_widget = workspace.getWidgetByName(
args.target_widget_name as string,
)!;
);

return target_widget.title.label !== "";
return target_widget?.title.label !== "";
},
label: (args) => {
const target_widget = workspace.getWidgetByName(
Expand Down Expand Up @@ -194,9 +194,9 @@ export const createCommands = (
isVisible: (args) => {
const widget = workspace.getWidgetByName(
args.widget_name as string,
)!;
);

return widget.parent! === (workspace.get_dock_panel() as Widget)
return widget?.parent === (workspace.get_dock_panel() as Widget)
? true
: false;
},
Expand All @@ -220,8 +220,10 @@ export const createCommands = (
),
// iconClass: "menu-duplicate",
isVisible: (args) => {
return workspace.getWidgetByName(args.widget_name as string)!
.parent! === (workspace.get_dock_panel() as Widget)
const parent = workspace.getWidgetByName(
args.widget_name as string,
)?.parent;
return parent === (workspace.get_dock_panel() as Widget)
? true
: false;
},
Expand Down
Loading