Conversation
aurickq
suggested changes
Nov 30, 2020
aurickq
suggested changes
Nov 30, 2020
| WORKDIR /root | ||
| COPY bert_config.json bert_config.json | ||
| COPY tf_examples.tfrecord tf_examples.tfrecord | ||
| COPY autodist autodist |
Contributor
There was a problem hiding this comment.
Some of these COPY commands cannot work in a fresh clone of the AdaptDL repo? Can you make sure this example can work in that setting? Maybe git clone autodist instead of assuming it exists locally?
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 61.16% 61.18% +0.01%
==========================================
Files 30 30
Lines 2243 2334 +91
Branches 338 357 +19
==========================================
+ Hits 1372 1428 +56
- Misses 806 834 +28
- Partials 65 72 +7
Continue to review full report at Codecov.
|
jessezbj
reviewed
Jan 7, 2021
| return_list = [(pod_ip_list[i], pod_gpu_list[i]) | ||
| for i in range(len(pod_ip_list))] | ||
| LOG.info(return_list) | ||
| return web.json_response(return_list) |
Contributor
There was a problem hiding this comment.
shall we unify the return values with L87?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.