Skip to content

Conversation

@akshay-joshi
Copy link
Contributor

@akshay-joshi akshay-joshi commented Jan 22, 2026

Summary by CodeRabbit

  • New Features

    • Added INHERIT and SET options in Role's membership tab.
  • Bug Fixes

    • Fixed password cell tooltip visibility.
    • Enhanced SSL password field with masked input for improved security.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Walkthrough

Documentation and UI updates address password field visibility and SSL parameter handling. The SSL password connection parameter changed from text to password input type. A new disableTooltip prop was added to password cells to prevent tooltip exposure, with cell behavior evaluation to control this setting.

Changes

Cohort / File(s) Summary
Documentation Update
docs/en_US/release_notes_9_12.rst
Added release notes entries for Issue #6451 (Role membership options: INHERIT and SET) and Issue #9552 (password cell tooltip visibility fix).
Connection Parameters
web/pgadmin/browser/server_groups/servers/static/js/server.ui.js
Changed SSL password parameter vartype from 'string' to 'password' in getConnectionParameters().
Cell Rendering Logic
web/pgadmin/static/js/SchemaView/DataGridView/row.jsx
Added evalFunc import and cell behavior evaluation. Passes new disableTooltip prop to PgReactTableCell for password-type cells.
Table Cell Component
web/pgadmin/static/js/components/PgReactTableStyled.jsx
Added disableTooltip boolean prop to PgReactTableCell. Suppresses title attribute (tooltip) when enabled; otherwise uses existing derived string value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: preventing password cell tooltips from displaying, which is the main focus across multiple file changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adityatoshniwal adityatoshniwal merged commit 31d1dbc into pgadmin-org:master Jan 22, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants