Add ignoreCheckUploadedFile option to File validator (Fixes #16710) #16821
+149
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
is_uploaded_filecheck in File validator #16710In raising this pull request, I confirm the following:
Small description of change:
This PR implements the
ignoreCheckUploadedFileoption in theFilevalidator, allowingdevelopers to bypass the internal
is_uploaded_file()check. This option is particularlyuseful when mocking uploaded files in unit tests.
Additionally, when
ignoreCheckUploadedFileis set totrue, empty upload arrays(e.g.
[]) are now treated as valid rather than causing a validation failure.This update improves testability while maintaining backwards compatibility.
A unit test has been added to verify this behavior.
Note: I did not update the CHANGELOG because Phalcon maintainers usually handle it on merge.
If it is preferred that contributors update it, I’m happy to add it.
Thanks