fixed RESIZE-FILE #198
Merged
fixed RESIZE-FILE #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philburk
approved these changes
Jan 21, 2025
Owner
philburk
left a comment
philburk
left a comment
There was a problem hiding this comment.
Thanks. This is a bit tricky but it seems right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #189 .
Since we were already through the looking glass anyway (by putting NetBSD specific code into /csrc/stdio/pf_fileio_stdio.c)
and Cygwin stil did not work, the cleaner solution was to implement TruncateFile via Unix-API.
This was tested (make clean test) on Cygwin/MSYS2, FreeBSD, NetBSD, Linux/Manjaro.