Split up conky.config. #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will hopefully make them easier to maintain in the long term. The main polycore config all the examples and tests have been updated although the test suite isn't rendering for me. For now the split is as follows, but open to changes and suggestions:
* widget_core * Widget * Rows * Columns * Filler * Frame
* widget_cpu
* Cpu
* CpuRound * CpuFrequencies
* widget_drive * Drive
* widget_gpu
* Gpu
* GpuTop
* widget_graph - This could have a better name * Bar * Graph * LED
* widget_memory
* MemoryBar
* MemoryGrid
* widget_network * Network
* widget_text
* Text
* StaticText * TextLine
* Now paint the backgrounds in the pre section. * Unfortunatly we need to clear and repaint all backgrounds every cycle, unless we want to start tracking which widgets overlap others.
Rather then re rendering widget backgrounds every update they are now rendered to a separate surface which is remerged with the main surface when it is cleared.
* Don't line up requires * Don't worry about aliasing module names
Config is now split into 3 parts and merged dynamically: * core config - this should always be the same for polycore * wm config - window manager specific issues * script config - config specific to this instance / theme The script config is able to overwrite any of the other options if desired. The reason for this is two fold. 1 i'm sick of dealing with some of the differences here, 2 as themes move more toward being lua only like some of the examples i'd like to reduce the amount of unneeded code in the main configuration file.
Author
|
To make your life easier you only actually need to review the last commit f29db35 It is just rebased on top of the "Split Widgets" branch to make my life easier. This is the last of the big changes I can think of from here it should only be adding new features rather then rewriting / refactoring existing stuff. Thankyou for your patience and time. |
Currently it breaks everything lua based on my machine brndnmtthws/conky#1528 Still manually use it for the main config though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config is now split into 3 parts and merged dynamically:
The script config is able to overwrite any of the other options
if desired.
The reason for this is two fold. 1 i'm sick of dealing with some
of the differences here, 2 as themes move more toward being lua
only like some of the examples i'd like to reduce the amount of
unneeded code in the main configuration file.