Skip to content

Ak/issue 14 wip#20

Merged
AnilKumar3494 merged 37 commits intomainfrom
ak/issue-14-WIP
Feb 10, 2026
Merged

Ak/issue 14 wip#20
AnilKumar3494 merged 37 commits intomainfrom
ak/issue-14-WIP

Conversation

@AnilKumar3494
Copy link
Member

No description provided.

@RNR1 RNR1 marked this pull request as draft January 28, 2026 02:05
@AnilKumar3494 AnilKumar3494 self-assigned this Jan 28, 2026
@AnilKumar3494 AnilKumar3494 requested a review from RNR1 January 29, 2026 03:49
@AnilKumar3494
Copy link
Member Author

this should solve: Issue14

@AnilKumar3494 AnilKumar3494 marked this pull request as ready for review February 2, 2026 14:27
Copy link

@marcbachan marcbachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we did a fair bit of review as a group last week, but I looked through again and ran your latest changes to verify the boilerplate setup:

Image

Just left a comment on being explicit about setting up the .env. This was a blocker for @RaulBSanchez when we connected on this earlier, as it wasn't super clear that was what needed to be done.

Copy link

@marcbachan marcbachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work!

Copy link
Contributor

@RNR1 RNR1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, a few cleanups before LGTM!

@AnilKumar3494 AnilKumar3494 requested a review from RNR1 February 6, 2026 01:26
Removed resources, sitesponsors, and users components from routes section. Also removed db utility file from utils section.
Copy link
Member Author

@AnilKumar3494 AnilKumar3494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be GTG

Copy link
Contributor

@RNR1 RNR1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions before LGTM

Copy link
Member Author

@AnilKumar3494 AnilKumar3494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be all set!

Copy link
Contributor

@RNR1 RNR1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for addressing all the comments

@AnilKumar3494 AnilKumar3494 merged commit 8030414 into main Feb 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants