Skip to content

Add note about SORT_REGULAR + numeric strings bug to array_unique() #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add note about SORT_REGULAR + numeric strings bug to array_unique() #4958

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00f461c
Add note about SORT_REGULAR + numeric strings bug to array_unique()
shaedrich Oct 27, 2025
e3aaa50
Fix indention
shaedrich Oct 27, 2025
534eb81
Use <para> instead of <simpara>
shaedrich Oct 27, 2025
3f51051
Make text more precise
shaedrich Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions reference/array/functions/array-unique.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,17 @@
Comparison type flags:
<itemizedlist>
<listitem>
<simpara><constant>SORT_REGULAR</constant> - compare items normally
(don't change types)</simpara>
<para>
<constant>SORT_REGULAR</constant> - compare items normally
(don't change types)
<note>
<simpara>
Be careful when using this flag in combination with numeric strings
as array values since this causes them to not be filtered out
Copy link

@macropay-solutions macropay-solutions Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can be more precise. "Can result in duplicate values"

Copy link
Contributor Author

@shaedrich shaedrich Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't sure how to word it to not make the text too long 😅

Copy link

@macropay-solutions macropay-solutions Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this flag can result in duplicate values like: [5, 10, '3A', 5]

Copy link
Contributor Author

@shaedrich shaedrich Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay—I'd leave that to the maintainers

correctly and you end up with duplicated values.
</simpara>
</note>
</para>
</listitem>
<listitem>
<simpara><constant>SORT_NUMERIC</constant> - compare items numerically</simpara>
Expand Down