-
Notifications
You must be signed in to change notification settings - Fork 158
Update TiDB team membership and reviewer lists #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find how these roles are related to PingCAP company. And
Membership of the maintainers can be revoked by a consensus vote of all the maintainers other than the member in question.
this is a hard work
https://github.com/pingcap/community/tree/master/teams#roles-and-responsibilities
[LGTM Timeline notifier]Timeline:
|
|
If you are concerned about the code security in the company's software repository, the code owner mechanism should be sufficient to ensure that company employees who are more familiar with the development context can review the code. This community PR is unnecessary. |
| "b41sh", | ||
| "cbcwestwolf", | ||
| "chrysan", | ||
| "crazycs520", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seriously?
We do not nominate reviewers/committers because "they have some jobs". I think it's better to add the 'inactive roles' when those reviewers/committers do not participate in TiDB community for a long time. |
|
According to the governance rules of teams: https://github.com/pingcap/community/tree/master/teams. If you want to remove a maintainer, please initiate a vote. Moreover, since this time involves many people being changed, I request initiating a ToC vote for discussion and decision-making. |
|
/assign Benjamin2037 |
|
This doesn’t seem like a proper community initiative, as long as we are still a community. Retiring committers or maintainers should go through a voting process, not just a random PR. If the concern is about code privileges, we should investigate what went wrong with the current privilege management mechanism and fix it, rather than banning someone for making so-called “trouble”. |
This pull request updates the TiDB team membership configuration to reflect current roles and responsibilities. The main changes involve moving several contributors between the
maintainers,committers, andreviewerslists in theteams/tidb/membership.jsonfile due to reasons such as resignation, job changes, etc. Ensuring that team permissions are up to date to better control the integration quality of the repository's code.Membership updates:
maintainersandcommittersto thereviewerslist, reflecting a reorganization of team roles. [1] [2]