Support Non-recursive CTE spill in TiFlash #10381
Conversation
ti-chi-bot
bot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XXL
|
/retest |
|
/cc @gengliqi |
|
/cc @windtalker @gengliqi |
|
/cc @gengliqi |
|
|
||
| ~CTE() | ||
| { | ||
| // TODO delete --------------- |
There was a problem hiding this comment.
It seems that a lot of code should be deleted.
There was a problem hiding this comment.
It seems that a lot of code should be deleted.
I will delete them before merge of the pr
dbms/src/Operators/CTESinkOp.cpp
Outdated
| { | ||
| case CTEOpStatus::WAIT_SPILL: | ||
| // CTE is spilling blocks to disk, we need to wait the finish of spill | ||
| DB::setNotifyFuture(&(this->io_notifier)); |
There was a problem hiding this comment.
| DB::setNotifyFuture(&(this->io_notifier)); | |
| setNotifyFuture(&(this->io_notifier)); |
dbms/src/Operators/CTESinkOp.cpp
Outdated
| return OperatorStatus::CANCELLED; | ||
| case CTEOpStatus::WAIT_SPILL: | ||
| // CTE is spilling blocks to disk, we need to wait the finish of spill | ||
| DB::setNotifyFuture(&(this->io_notifier)); |
dbms/src/Operators/CTESourceOp.cpp
Outdated
| block = this->block_from_disk; | ||
| this->block_from_disk.clear(); |
There was a problem hiding this comment.
| block = this->block_from_disk; | |
| this->block_from_disk.clear(); | |
| block.swap(block_from_disk); |
2 participants
What problem does this PR solve?
Issue Number: close #10085
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note