Skip to content

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Oct 16, 2025

What problem does this PR solve?

Issue Number: close #10481

Problem Summary:
disable two-level hash table for fine-grained agg if spill is not needed.
In fact, for fine grained hash agg, we should also use a new spill algorithm for fine grained agg(we can actually spill data by threads instead of convert the hash table into two-level hash table), but this pr just keep the original behavior if spill is enabled.

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: xufei <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Oct 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-16 07:31:58.107008103 +0000 UTC m=+338624.184260664: ☑️ agreed by gengliqi.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2025

@windtalker: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 54667d6 link true /test pull-unit-test
pull-unit-next-gen 54667d6 link true /test pull-unit-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fine-grained agg should not enable two-level hash table if no spill is needed

2 participants