Skip to content

Conversation

@wlwilliamx
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #12361

What is changed and how it works?

This PR completely removes the "Check & Build" GitHub Actions workflow by deleting the .github/workflows/check_and_build.yaml file.

Why is this change necessary?

The "Check & Build" workflow is a known source of instability and random failures. These failures often have no connection to the code changes being proposed in a pull request.

Crucially, these jobs are not required checks for merging a PR. However, their failure frequently confuses contributors, leading them to believe their PR is blocked. This creates unnecessary noise and requires developers to investigate non-critical issues.

By removing this workflow, we aim to:

  • Eliminate a flaky and unstable CI process.
  • Reduce confusion for developers during the PR process.
  • Save CI resources that were being used on these non-essential builds.

What has been changed?

The file .github/workflows/check_and_build.yaml has been deleted. This action removes the following CI jobs that were previously triggered on pull requests and pushes to master and release branches:

  1. docker_build: This job ran on ubuntu-latest and executed the following steps:

    • docker build -f ./deployments/ticdc/docker/Dockerfile .
    • docker build -f ./dm/Dockerfile .
    • docker build -f ./deployments/engine/docker/Dockerfile .
  2. mac_build: This job ran on macos-latest and was responsible for:

    • Setting up the Go v1.23 environment.
    • Running make build.
    • Running make check.
  3. arm_build: This job ran on a self-hosted ARM64 runner and was responsible for:

    • Setting up the Go v1.23 environment.
    • Running make build.

The removal of the file also gets rid of the workflow's trigger conditions and concurrency settings.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?

None

Do you need to update user documentation, design documentation or monitoring documentation?

None

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Oct 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2025

@OliverS929: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wlwilliamx
Copy link
Contributor Author

/retest

1 similar comment
@wlwilliamx
Copy link
Contributor Author

/retest

Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2025

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lidezhu, OliverS929, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-16 03:24:38.224882766 +0000 UTC m=+323784.302135326: ☑️ agreed by lidezhu.
  • 2025-10-20 09:10:05.212424207 +0000 UTC m=+690111.289676757: ☑️ agreed by wk989898.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/cherry-pick-not-approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants