-
Notifications
You must be signed in to change notification settings - Fork 294
ci(*): deprecate github action jobs to prevent developer misunderstanding and interference #12365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-6.5
Are you sure you want to change the base?
ci(*): deprecate github action jobs to prevent developer misunderstanding and interference #12365
Conversation
…ding and interference
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
@OliverS929: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
1 similar comment
|
/retest |
Benjamin2037
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, lidezhu, OliverS929, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #12361
What is changed and how it works?
This PR completely removes the "Check & Build" GitHub Actions workflow by deleting the
.github/workflows/check_and_build.yamlfile.Why is this change necessary?
The "Check & Build" workflow is a known source of instability and random failures. These failures often have no connection to the code changes being proposed in a pull request.
Crucially, these jobs are not required checks for merging a PR. However, their failure frequently confuses contributors, leading them to believe their PR is blocked. This creates unnecessary noise and requires developers to investigate non-critical issues.
By removing this workflow, we aim to:
What has been changed?
The file
.github/workflows/check_and_build.yamlhas been deleted. This action removes the following CI jobs that were previously triggered on pull requests and pushes tomasterandreleasebranches:docker_build: This job ran onubuntu-latestand executed the following steps:docker build -f ./deployments/ticdc/docker/Dockerfile .docker build -f ./dm/Dockerfile .docker build -f ./deployments/engine/docker/Dockerfile .mac_build: This job ran onmacos-latestand was responsible for:v1.23environment.make build.make check.arm_build: This job ran on a self-hostedARM64runner and was responsible for:v1.23environment.make build.The removal of the file also gets rid of the workflow's trigger conditions and concurrency settings.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
None
Do you need to update user documentation, design documentation or monitoring documentation?
None
Release note